-
Notifications
You must be signed in to change notification settings - Fork 155
Bump CategoricalArrays, etc and major testing change 😱 #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Packages that are to be permanently removed from integration tests: | BetaML │ CatBoost │ MLJXGBoostInterface │ MLJScikitLearnInterface │ OutlierDetectionNeighbors │ SIRUS │ MLJTSVDInterface │ PartitionedLS │ Maxnet │ ParallelKMeans │ MLJNaiveBayesInterface │ Imbalance │ EvoLinear │ LightGBM │ LaplaceRedux │ MLJText
|
For comparison, can you post the list of packages for which we'll continue running the integration tests? |
|
cc @OkonSamuel |
|
Sure, they are: Basically everything in [extras] |
|
These are all packages we maintain ourselves anyway, except EvoTrees, which is very popular, very-well maintained over a long period, with responsive lead developer. Even this list may be longer than really necessary, I reckon. |
|
BTW, While integration tests are begin skipped in this PR (because base of merge is not |
DilumAluthge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me, especially if it will free up some of your time.
This PR bumps the stated compatibility requirements (to close the substantial #1172) but also pares down the number of packages included in MLJ integration tests. Integration tests for the following packages are being permanently removed:
| BetaML
│ CatBoost
│ MLJXGBoostInterface
│ MLJScikitLearnInterface
│ OutlierDetectionNeighbors
│ SIRUS
│ MLJTSVDInterface
│ PartitionedLS
│ Maxnet
│ ParallelKMeans
│ MLJNaiveBayesInterface
│ Imbalance
│ EvoLinear
│ LightGBM
│ LaplaceRedux
│ MLJText
I am deeming this necessary because: