Skip to content

Conversation

@DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jun 13, 2021

Closes #304

Here is this diff for this PR versus PR #304: aa/codecov-v4...dpa/codecov-v4

@coveralls
Copy link

coveralls commented Jun 13, 2021

Pull Request Test Coverage Report for Build 933962705

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 90.64%

Files with Coverage Reduction New Missed Lines %
src/coveralls.jl 2 94.23%
src/codecovio.jl 3 86.87%
Totals Coverage Status
Change from base Build 926834392: 0.3%
Covered Lines: 184
Relevant Lines: 203

πŸ’› - Coveralls

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #318 (0b0e47e) into master (b79485e) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   90.30%   90.64%   +0.33%     
==========================================
  Files           2        2              
  Lines         196      203       +7     
==========================================
+ Hits          177      184       +7     
  Misses         19       19              
Impacted Files Coverage Ξ”
src/codecovio.jl 86.86% <100.00%> (+3.17%) ⬆️
src/coveralls.jl 94.23% <0.00%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b79485e...0b0e47e. Read the comment docs.

@DilumAluthge DilumAluthge force-pushed the dpa/codecov-v4 branch 3 times, most recently from 07ec767 to bc27ab7 Compare June 13, 2021 20:59
@DilumAluthge DilumAluthge marked this pull request as ready for review June 13, 2021 21:02
@DilumAluthge DilumAluthge requested review from ararslan and vtjnash June 13, 2021 21:03
@DilumAluthge
Copy link
Member Author

@vtjnash @ararslan Take a look at this PR and let me know what you think.

@DilumAluthge
Copy link
Member Author

Also, changing the version of the Codecov API that we use - is that a breaking change or a nonbreaking change?

@ararslan
Copy link
Member

It's not really exposed to the user in terms of API, so IMO not breaking

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Jun 13, 2021

It's not really exposed to the user in terms of API, so IMO not breaking

Sounds good to me!

I have bumped the minor version number.

@DilumAluthge DilumAluthge changed the title Update Codecov upload API to v4 Update Codecov upload API to v4 (replacement for #304) Jun 13, 2021
@DilumAluthge DilumAluthge merged commit 996d94c into master Jun 13, 2021
@DilumAluthge DilumAluthge deleted the dpa/codecov-v4 branch June 13, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants