-
Notifications
You must be signed in to change notification settings - Fork 37
fftshift! and ifftshift!
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 82.75% 82.92% +0.16%
==========================================
Files 2 2
Lines 203 205 +2
==========================================
+ Hits 168 170 +2
Misses 35 35
Continue to review full report at Codecov.
|
|
Looks overall ok to me, but probably for consistency the allocating versions should be based on the non-allocating ones? Also, add backreferences in the docstrings of the allocating functions. However I'm not familiar with the internals of this package. Anyone else who can give another review pass? Maybe @stevengj? |
backreferences to non-allocating functions.
|
@giordano Sorry for the delay. I've implemented your suggestions. |
|
I have added all your suggestions, @stevengj. |
Adds nonallocating versions of
fftshiftandifftshiftwith the corresponding tests. Fixes #62