Skip to content

Conversation

@Gregstrq
Copy link
Contributor

Adds nonallocating versions of fftshift and ifftshift with the corresponding tests. Fixes #62

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #66 (bdcf670) into master (4f630d6) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   82.75%   82.92%   +0.16%     
==========================================
  Files           2        2              
  Lines         203      205       +2     
==========================================
+ Hits          168      170       +2     
  Misses         35       35              
Impacted Files Coverage Δ
src/definitions.jl 65.34% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f630d6...bdcf670. Read the comment docs.

@giordano
Copy link
Member

Looks overall ok to me, but probably for consistency the allocating versions should be based on the non-allocating ones? Also, add backreferences in the docstrings of the allocating functions. However I'm not familiar with the internals of this package. Anyone else who can give another review pass? Maybe @stevengj?

@Gregstrq
Copy link
Contributor Author

@giordano Sorry for the delay. I've implemented your suggestions.

@Gregstrq
Copy link
Contributor Author

I have added all your suggestions, @stevengj.

@stevengj stevengj merged commit 6434327 into JuliaMath:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing fftshift! and ifftshift!

3 participants