Skip to content

Conversation

@devmotion
Copy link
Member

This PR updates the Github actions, switches to julia-actions/cache and adds proper versioning to all actions (with dependabot we don't have to worry about outdated actions but rather about breaking updates IMO).

Closes #90. Closes #92. Closes #91.

@ararslan ararslan merged commit a25656d into master Mar 16, 2023
@ararslan ararslan deleted the dw/actions branch March 16, 2023 15:32
@gaurav-arya
Copy link
Contributor

gaurav-arya commented Mar 16, 2023

Code coverage (upload) doesn't work with the updates here. See the error logged for the codecov-action in e.g. https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/4428264794/jobs/7767085981

@ararslan
Copy link
Member

Doesn't look obviously related to me. Open source repositories don't require a token for submitting coverage information to Codecov so if it's having trouble with the GitHub API then that's either on Codecov's end or GitHub's (or both).

@devmotion
Copy link
Member Author

Also it seems codecov was already updated on the master branch before this PR: #90 And there the action ran successfully, eg in https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/4428612759/jobs/7767949971

@gaurav-arya
Copy link
Contributor

I see, perhaps it's independent then. codecov/codecov-action#557 <- thought it might be related because this issue mentions that upgrading caused sporadic failures

@devmotion
Copy link
Member Author

Based on this issue it seems intermittent issues occur quite regularly but possibly one could avoid them by adding the CODECOV_TOKEN as a secret (and to the action, of course), even though it should not be needed for public repos according to the docs.

@devmotion
Copy link
Member Author

As an additional datapoint, the action did also succeed on the master branch when this PR was merged: https://github.com/JuliaMath/AbstractFFTs.jl/actions/runs/4438818860/jobs/7790407281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants