Introduce TZSource for managing tzdata source files
#172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamed2
requested changes
Jan 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 91.85% 91.82% -0.03%
==========================================
Files 25 25
Lines 982 1003 +21
==========================================
+ Hits 902 921 +19
- Misses 80 82 +2
Continue to review full report at Codecov.
|
ararslan
reviewed
Jan 7, 2019
ararslan
reviewed
Jan 7, 2019
ararslan
reviewed
Jan 7, 2019
ararslan
approved these changes
Jan 7, 2019
iamed2
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I work towards parsing both standard time zones and legacy time zones I need a nice way of containing the intermediate representation of the tz source files. The
TZSourcestructure allows me to do this by having a Julia representation of the tz source files in a single struct. Additionally, part of this work required me to solve an issue where tz links can reference time zone names in other tz source files. This intermediate representation is also helpful in that scenario.