Skip to content

auth 4.9: backport "allow finer-grained rrset changes through the API" #16600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
miodvallat wants to merge 13 commits into
base: rel/auth-4.9.x
Choose a base branch
from
Open

auth 4.9: backport "allow finer-grained rrset changes through the API" #16600

miodvallat wants to merge 13 commits into from
+662 −154

Conversation

@miodvallat
Copy link
Contributor

@miodvallat miodvallat commented Dec 5, 2025

Short description

Backport of #16589 to 4.9.x
But:

  • commit 8e1a068 which only matters for tests is omitted and replaced by the last commit, which contains that commit and various bits from older commits in master which I have been too lazy to identify. (no cookie for me)
  • with commit 6716169 as first commit; not from the abovementioned PR, but this "split patchZone() into smaller pieces" commit is required to give the backport a chance to apply without too many conflicts.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

miodvallat and others added 10 commits December 5, 2025 15:31
@miodvallat
Rework patchZone() signature and split it in multiple pieces. NFC
a003a48 
Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit 6716169)
@miodvallat
Split patchZone() in smaller bits.
4f8d3c8 
This is preparation work for future changes which would likely to trigger
the "excessive cognitive complexity" diagnostic from clang-tidy, so cut
ahead.

Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit a8e5702)
@miodvallat
New API zone patch feature: individual record add/delete (not rrset).
688418d 
Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit acd2c6b)
@miodvallat
Tests for EXTEND and PRUNE zone patch operations.
406ad45 
Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit ab0a342)
@miodvallat
Allow for multiple extend/prune in the same request as long as differ…
37cee20 
…ent RRsets.

Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit 9017ef0)
@miodvallat
Logic buglet found during review.
77996df 
Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit e13f3db)
@miodvallat @jsoref
Spelling fixes from review
3918738 
Co-authored-by: Josh Soref <[email protected]>
Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit d2415df)
@miodvallat
Allow PRUNE/EXTEND to coexist with DELETE/REPLACE.
e4ff8aa 
This causes us to maintain a local cache of the rrsets being modified by
both sets of operations, so that we keep a consistent view of them during
the backend transaction, regardless of what the backend might be able to
return.

Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit 923b4b7)
@miodvallat
No more reasons to reject more than one EXTEND or PRUNE anymore.
766fcba 
Signed-off-by: Miod Vallat <[email protected]>
(cherry picked from commit 6425264)
@miodvallat
Add latest version of assert_in_json_error for the new tests to pass.
e254cce 
Signed-off-by: Miod Vallat <[email protected]>
@miodvallat miodvallat added the auth label Dec 5, 2025
@coveralls
Copy link

coveralls commented Dec 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 19967975374

Details

  • 237 of 258 (91.86%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 63.225%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/ws-auth.cc 237 258 91.86%
Files with Coverage Reduction New Missed Lines %
pdns/ws-auth.cc 1 81.89%
pdns/opensslsigners.cc 3 60.37%
ext/lmdb-safe/lmdb-safe.cc 6 74.47%
Totals Coverage Status
Change from base Build 19738700427: 0.1%
Covered Lines: 42011
Relevant Lines: 59699
💛 - Coveralls

@Habbie
Copy link
Member

Habbie commented Dec 7, 2025

note to self: the doc changes in the original PR did not note "since version ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miodvallat @coveralls @Habbie