Merged
Conversation
Owner
That's completely fine. Ymir technically builds on Windows ARM64 as well, but the build script doesn't include this target because the runner image lacks Ninja.
Thanks for catching that! I was wondering why the option had no effect... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added FreeBSD x64 to CI and updated COMPILING to be more consistent with the CI.
Arm64 throws the following errors:
I currently don't know what's the cause for this error, seems something specific to FreeBSD arm64 and maybe even the compiler. Because I don't have a arm64 system to debug and test, I excluded this architecture from CI for now.
While there, fixed the (intended) Ymir_ENABLE_IPO usage in the CI.