Switch over to github actions for building our nightly docker image#7775
Switch over to github actions for building our nightly docker image#7775jamesemery merged 8 commits intomasterfrom
Conversation
lbergelson
left a comment
lbergelson
left a comment
There was a problem hiding this comment.
@jamesemery Looks google to me. Have you run the generated docker and made sure it doesn't explode?
| schedule: | ||
| # trigger the job the image at 1am est every night (UTC 20:00) | ||
| # NOTE: by default schedule:cron jobs pull from the repo default branch which makes this the master branch of gatk | ||
| - cron: '0 20 * * *' |
There was a problem hiding this comment.
cron has such a weird notation for timing.
| images: broadinstitute/gatk-nightly | ||
| tags: | | ||
| type=raw,value=${{env.DOCKER_NIGHTLY_TAG}} | ||
| type=raw,value=${{env.DOCKER_NIGHTLY_TAG_LATEST}} |
There was a problem hiding this comment.
If you feel like learning the docker tag domain specific language you can probably do this same thing with their magic built ins. I think it's reasonable to NOT do that though.
There was a problem hiding this comment.
I spent some time looking into that and it looked neat but i figure its probably better to keep the images using the same name scheme as before
| jobs: | ||
| buildDocker: | ||
| name: build docker images | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
I hadn't thought about this before, but we can probably save 20 seconds by using alpine linux instead of ubuntu. Kind of useless savings though.
2 participants
No description provided.