Changing the cron trigger to hopefully reduce the change of jobs being dropped.#7784
Merged
jamesemery merged 5 commits intomasterfrom Apr 15, 2022
Merged
Changing the cron trigger to hopefully reduce the change of jobs being dropped.#7784jamesemery merged 5 commits intomasterfrom
jamesemery merged 5 commits intomasterfrom
Conversation
droazen
suggested changes
Apr 14, 2022
| # trigger the job the image at 1am est every night (UTC 20:00) | ||
| # NOTE: by default schedule:cron jobs pull from the repo default branch which makes this the master branch of gatk | ||
| - cron: '0 20 * * *' | ||
| - cron: '17 20 * * *' # trigger the job the image at 1:17am est every night (UTC 20:17) |
Contributor
There was a problem hiding this comment.
UTC 20:17 is actually 4:17 PM Eastern, I believe...
droazen
suggested changes
Apr 14, 2022
| # trigger the job the image at 1am est every night (UTC 20:00) | ||
| # NOTE: by default schedule:cron jobs pull from the repo default branch which makes this the master branch of gatk | ||
| - cron: '0 20 * * *' | ||
| - cron: '17 05 * * *' # trigger the job the image at 1:17am est every night (UTC 05:17) |
Contributor
There was a problem hiding this comment.
It's actually 1:17 AM EDT (Eastern Daylight Time), but 12:17 AM EST (Eastern Standard Time). Can you update the comment?
Author
There was a problem hiding this comment.
good point. I don't know how time zones work
droazen
approved these changes
Apr 14, 2022
Contributor
droazen
left a comment
droazen
left a comment
There was a problem hiding this comment.
One typo, then this can be merged. You should wait until well after 4 PM, however, to test whether the build scheduled for today happens -- recommend waiting until 5 PM.
| # trigger the job the image at 1am est every night (UTC 20:00) | ||
| # NOTE: by default schedule:cron jobs pull from the repo default branch which makes this the master branch of gatk | ||
| - cron: '0 20 * * *' | ||
| - cron: '17 05 * * *' # trigger the job the image at 12:17am EST every night (UTC 05:17) |
Contributor
There was a problem hiding this comment.
"the job the image" -> "the job to build the image"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.