Allow empty input in TransferReadTags#8198
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8198 +/- ##
===============================================
- Coverage 86.658% 86.651% -0.007%
- Complexity 39024 39155 +131
===============================================
Files 2337 2346 +9
Lines 182961 183623 +662
Branches 20079 20148 +69
===============================================
+ Hits 158550 159111 +561
- Misses 17365 17449 +84
- Partials 7046 7063 +17
|
tmelman
suggested changes
Feb 13, 2023
Contributor
tmelman
left a comment
There was a problem hiding this comment.
Add test where 1 file has 0 and 1 file has x reads to see that it fails with UserException; add test where both have 0 reads to see that warning is raised and output has 0 reads.
Contributor
Author
|
@tmelman I have added tests, so this is ready for another round of review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransferReadTags will throw an exception if the unaligned bam has no read. This pr will allow the unaligned bam to have 0 reads, as long as the aligned bam also has 0 reads, which will result in an output bam which is just a copy of the aligned bam, with 0 reads.