refactor: deprecate StatusBase.register decorator#1384
Merged
james-garner-canonical merged 4 commits intocanonical:mainfrom Sep 23, 2024
Merged
Conversation
james-garner-canonical
requested review from
IronCore864,
benhoyt,
dimaqq and
tonyandrewmeyer
benhoyt
reviewed
Sep 22, 2024
tonyandrewmeyer
approved these changes
Sep 22, 2024
Collaborator
tonyandrewmeyer
left a comment
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
LGTM! Small test suggestion and a question for Ben.
james-garner-canonical
force-pushed
the
status-base-init-subclass-deprecate-register
branch
from
0782be2 to
75eb180
Compare
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Oct 4, 2024
As `StatusBase.__init_subclass__` is now used to automatically register status classes by name, and the old `StatusBase.register` decorator shouldn't have been public in the first place, it is now deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
StatusBase.__init_subclass__is now used to automatically register status classes by name, and the oldStatusBase.registerdecorator (1) shouldn't have been public, (2) shouldn't have been used externally anyway, (3) doesn't appear to be used in charms currently, and (4) isn't needed internally, let's deprecate it.See also discussion on #1380.