docs: use load_config in the httpbin example charm#1852
Merged
tonyandrewmeyer merged 3 commits intocanonical:mainfrom Jul 4, 2025
Merged
docs: use load_config in the httpbin example charm#1852tonyandrewmeyer merged 3 commits intocanonical:mainfrom
tonyandrewmeyer merged 3 commits intocanonical:mainfrom
Conversation
Collaborator
Author
|
Leaving in draft until the required version of ops is released. |
james-garner-canonical
approved these changes
Jun 30, 2025
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Look good!
Co-authored-by: James Garner <james.garner@canonical.com>
tonyandrewmeyer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic config class to the httpbin example charm, and uses
load_configrather thanconfig. The class is a stdlib dataclass rather than apydantic.BaseModelbecause it seems pointless to require the largepydanticdependency for such a small use-case, where there's no value added other than recommending Pydantic.Fixes #1839