docs: update zero to hero to jubilant#1988
Merged
dimaqq merged 13 commits intocanonical:mainfrom Aug 19, 2025
Merged
Conversation
IronCore864
reviewed
Aug 13, 2025
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
IronCore864
approved these changes
Aug 13, 2025
dwilding
reviewed
Aug 13, 2025
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
I'm still reviewing (need to pause for a meeting).
BTW, the new/updated tutorial files will need to be added to the charms in examples/k8s-1-minimal and subsequent dirs
...ial/from-zero-to-hero-write-your-first-kubernetes-charm/create-a-minimal-kubernetes-charm.md
Outdated
Show resolved
Hide resolved
benhoyt
reviewed
Aug 14, 2025
...ial/from-zero-to-hero-write-your-first-kubernetes-charm/create-a-minimal-kubernetes-charm.md
Outdated
Show resolved
Hide resolved
dwilding
reviewed
Aug 14, 2025
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Show resolved
Hide resolved
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
...ial/from-zero-to-hero-write-your-first-kubernetes-charm/create-a-minimal-kubernetes-charm.md
Outdated
Show resolved
Hide resolved
…n-zero-to-hero-fixes
…n-zero-to-hero-fixes
Contributor
Author
|
Massive updated, I've requested fresh set of reviews. |
dwilding
approved these changes
Aug 18, 2025
Contributor
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
I tested tox -e integration for the two different sets of tests. No issues. Thanks for updating everything!
All suggestions are minor - most are for self-consistency
...ial/from-zero-to-hero-write-your-first-kubernetes-charm/create-a-minimal-kubernetes-charm.md
Outdated
Show resolved
Hide resolved
...ial/from-zero-to-hero-write-your-first-kubernetes-charm/create-a-minimal-kubernetes-charm.md
Outdated
Show resolved
Hide resolved
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
.../from-zero-to-hero-write-your-first-kubernetes-charm/integrate-your-charm-with-postgresql.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for a thorough review, @dwilding |
Contributor
Author
|
I've removed Tiexin from reviewers as he's on vacation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc preview: https://canonical-ubuntu-documentation-library--1988.com.readthedocs.build/ops/1988/
Updates:
Check list:
toxtoxtox -e integrationtoxtox -e integrationtoxtox -e integrationtoxtox -e integrationtoxtox -e integration