R2-3560: Implement ListParts and ListMultipartUploads for R2 Binding
#5596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schachte
reviewed
Nov 27, 2025
| { | ||
| partNumber: 1, | ||
| etag: 'partEtag1', | ||
| size: '100', |
There was a problem hiding this comment.
Why are we treating size as a string? (Sorry I am no C++/kj expert so maybe it's normal, but it seems a bit odd)
| key: string; | ||
| uploadId: string; | ||
| initiated?: Date; | ||
| storageClass?: string; |
There was a problem hiding this comment.
Maybe strongly type the storage class with a default?
Contributor
Author
There was a problem hiding this comment.
Need to think on this one a bit more. To my knowledge, we don't already do this for other operations, so might be worth updating them too. Not sure if that constitutes a breaking change though...
- Add range validation (1-1000) for `limit` parameter in `listMultipartUploads` - Change default limit from 0xffffffff to 0x3e8 (1000) in R2ListMultipartUploadsRequest - Fix `partNumberMarker` validation to require positive values (p > 0) instead of non-negative (p >= 0) - Fix `listParts` to pass JWT authentication token to doR2HTTPGetRequest
helloimalastair
force-pushed
the
list-binding-r2
branch
from
586c50e to
c1ecf41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass, may need polishing.