proposed solution for add 2 integers with max bit length #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
suggested changes
Sep 15, 2017
| " if carry != 0:\n", | ||
| " return self.sum_two(result, carry)\n", | ||
| " return result;" | ||
| " #max bit length, change to 32 for 32bit\n", |
Contributor
There was a problem hiding this comment.
Please add a single space between # and the comments according to PEP8.
| " while b != 0:\n", | ||
| " if b == max_positive:\n", | ||
| " return a ^ min_negative\n", | ||
| " a,b = a ^ b,(a&b)<<1\n", |
Contributor
There was a problem hiding this comment.
I am reading this just at github.
Here, the 4 space are correct? or there are less?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitwise add 2 integers solution will hit infinite loop for negative integers. Added max bit length to avoid exception