Skip to content

Conversation

@charlesroddie
Copy link
Contributor

Description

The type TupInfo was uncessary and not documented. It reduces to a bool (representing whether the tuple is a struct), allowing simplification of code. The uses of this bool are now documented as isStruct. A few methods can be simplified or deleted as a result.

NO_RELEASE_NOTES

@charlesroddie charlesroddie requested a review from a team as a code owner January 10, 2024 08:09
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@charlesroddie charlesroddie changed the title Tidy: simplify tuple info [WIP] Tidy: simplify tuple info Jan 10, 2024
@charlesroddie charlesroddie marked this pull request as draft January 10, 2024 08:23
@charlesroddie
Copy link
Contributor Author

charlesroddie commented Jan 20, 2024

I am doing something tiny in this PR to figure out the process again before doing something interesting.

Currently if I run build.cmd on my system on main I get

C:\Users\charl\source\repos\fsharp\buildtools\buildtools.targets(30,5): error MSB3073: The command ""C:\Program Files\d
otnet\dotnet.exe" "C:\Users\charl\source\repos\fsharp\artifacts\\Bootstrap\fslex\fslex.dll" -o "C:\Users\charl\source\r
epos\fsharp\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\illex.fs" --module FSharp.Compiler.AbstractIL.As
ciiLexer --internal --open Internal.Utilities.Text.Lexing --open FSharp.Compiler.AbstractIL.AsciiParser --unicode --lex
lib Internal.Utilities.Text.Lexing AbstractIL\illex.fsl" exited with code 1. [C:\Users\charl\source\repos\fsharp\src\Co
mpiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

@vzarytovskii
Copy link
Member

I am doing something tiny in this PR to figure out the process again before doing something interesting.

Currently if I run build.cmd on my system on main I get


C:\Users\charl\source\repos\fsharp\buildtools\buildtools.targets(30,5): error MSB3073: The command ""C:\Program Files\d

otnet\dotnet.exe" "C:\Users\charl\source\repos\fsharp\artifacts\\Bootstrap\fslex\fslex.dll" -o "C:\Users\charl\source\r

epos\fsharp\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\illex.fs" --module FSharp.Compiler.AbstractIL.As

ciiLexer --internal --open Internal.Utilities.Text.Lexing --open FSharp.Compiler.AbstractIL.AsciiParser --unicode --lex

lib Internal.Utilities.Text.Lexing AbstractIL\illex.fsl" exited with code 1. [C:\Users\charl\source\repos\fsharp\src\Co

mpiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

Hard to tell what's wrong, please run detailed build or collect the binlog, it should show whole error

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

3 participants