Skip to content

Conversation

@kush-elastic
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate K8s DaemonSets visualizations to the lens in the current Kibana version 8.10.2 itself.

  • Statistics for K8s DaemonSets Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Kubernetes] DaemonSets 1 4 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

Before Migration:
image

After Migration:
image

@kush-elastic kush-elastic marked this pull request as ready for review October 23, 2023 06:43
@kush-elastic kush-elastic requested review from a team as code owners October 23, 2023 06:43
@rajvi-patel-22 rajvi-patel-22 self-requested a review October 23, 2023 07:03
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…nto 7774-daemonSets-k8s-dashboard-lens-migration
@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-23T11:09:44.759+0000

  • Duration: 50 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 94
Skipped 0
Total 94

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 96.25% (77/80) 👎 -3.75
Lines 100.0% (22/22) 💚 4.523
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic self-assigned this Oct 23, 2023
@kush-elastic kush-elastic added enhancement New feature or request Integration:kubernetes Kubernetes dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Oct 23, 2023
…nto 7774-daemonSets-k8s-dashboard-lens-migration
@kush-elastic kush-elastic merged commit a89d7cf into elastic:main Oct 23, 2023
@elasticmachine
Copy link

Package kubernetes - 1.49.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@drewdaemon
Copy link
Contributor

Thanks for doing this! For the record, the new metric visualization works much better if the height of the panels is decreased, bringing the metric closer to the label. Here is an example

host-overview-light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:kubernetes Kubernetes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants