Skip to content

Conversation

@jtpio
Copy link
Contributor

@jtpio jtpio commented Dec 4, 2025

pytz is currently being imported and used here:

dt = datetime.datetime.now().astimezone(pytz.utc)

However currently it's not defined as part of the requirements.

And the next version of pandas will make pytz an optional dependency: https://pandas.pydata.org/docs/dev/whatsnew/v3.0.0.html#pytz-now-an-optional-dependency

@jtpio
Copy link
Contributor Author

jtpio commented Dec 4, 2025

This was noticed in jupyter-releaser, which has a check to test pre-releases: jupyter-server/jupyter_releaser#625 (comment)

Copy link
Collaborator

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bsipocz bsipocz added the bug Something isn't working label Dec 4, 2025
@bsipocz bsipocz merged commit 3ffc68f into executablebooks:main Dec 4, 2025
4 checks passed
@jtpio jtpio deleted the pytz branch December 4, 2025 16:36
@bsipocz
Copy link
Collaborator

bsipocz commented Dec 4, 2025

@choldgraf - interestingly CI was passing here, so I was happy that we can go ahead with the release straight away, however it's failing again on main. Is it still about hitting rate limit or something else? If just the rate limit I would still think we should tag a new release now as main is way better already than what's in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants