feature: Add wattage when adapter attached.#3024
Open
bhouston wants to merge 2 commits intoexelban:masterfrom
Open
feature: Add wattage when adapter attached.#3024bhouston wants to merge 2 commits intoexelban:masterfrom
bhouston wants to merge 2 commits intoexelban:masterfrom
Conversation
Read adapter current/voltage from external power details and only fall back to charger data when needed, so current is populated reliably. Format charging values in the popup as A/V instead of mA/mV to match expected display units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is build upon my previous PR here that fixed a data collection bug: #3023
I added this option in the battery section:
It then displays as a wattage (only when an adapter is plugged in) in the menu bar like this:
Or like this:
This is important to me so that I know if I am on an under powered adapter - there are so many different wattages of power adapters these days, and sometimes the USB cables you use also affect this.
Disclaimers: