chore: Use assertThrows in tests

[lqiu96]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the quality and maintainability of the BigQuery integration test suite. The core objective was to modernize exception handling by migrating from the verbose try-catch-fail pattern to the more expressive assertThrows method. Complementary changes include standardizing assertion styles and optimizing resource management, resulting in a cleaner, more readable, and robust test codebase.

Highlights

• Test Refactoring: Replaced numerous try-catch-fail blocks with the more modern and concise assertThrows method for validating expected exceptions across various BigQuery operations within the integration tests.
• Assertion Style Consistency: Standardized assertion patterns, such as updating assertTrue(condition.equals(value)) to assertEquals(value, condition) and assertThat().isNotEqualTo() to assertNotEquals(), for improved readability and consistency.
• Resource Management and Code Simplification: Introduced try-with-resources for TableDataWriteChannel in relevant tests and streamlined boolean assertions and return statements to make the test code more efficient and easier to understand.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily refactors tests to use assertThrows instead of try-catch-fail blocks, which is a great improvement for test readability and conciseness. The changes are mostly correct and well-implemented. I've found a few minor inconsistencies: some assertThrows conversions dropped the failure message, and there's a mix of assertion styles (JUnit vs. Truth) being introduced. I've added specific comments with suggestions to address these points for better consistency. Additionally, the PR includes other nice cleanups like removing unnecessary local variables and using try-with-resources.

[mpeddada1]

Perhaps we could also simplify the remaining assert statements further by using the Truth.assertThat?
Example: assertThat(exception).hasMessageThat().contains("...");