Skip to content

Specify that frame callbacks are not called without a base layer #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toji merged 2 commits into from
Feb 12, 2019
Merged

Specify that frame callbacks are not called without a base layer #512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924b1a2
Specify that frame callbacks are not called without a base layer
toji Feb 6, 2019
28fcc8e
Add check for null outputContext as well
toji Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,8 +523,10 @@ When the <dfn method for="XRSession">cancelAnimationFrame(|handle|)</dfn> method

When an {{XRSession}} |session| receives updated [=viewer=] state from the [=XR device=], it runs an <dfn>XR animation frame</dfn> with a timestamp |now| and an {{XRFrame}} |frame|, which MUST run the following steps regardless of if the [=list of animation frame callbacks=] is empty or not:

1. Let |callbacks| be a list of the entries in |session|'s [=list of animation frame callback=], in the order in which they were added to the list.
1. If |session|'s [=list of pending render states=] is not empty, [=apply pending render states=].
1. If |session|'s {{XRSession/renderState}}'s {{XRRenderState/baseLayer}} is <code>null</code>, abort these steps.
Copy link
Member

@NellWaliczek NellWaliczek Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a session is an inline session, should we also abort if there's no output context?

Copy link
Member Author

@toji toji Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Fixed.

1. If |session|'s {{XRSession/mode}} is {{XRSessionMode/inline}} and |session|'s {{XRSession/outputContext}} is <code>null</code>, abort these steps.
1. Let |callbacks| be a list of the entries in |session|'s [=list of animation frame callback=], in the order in which they were added to the list.
1. Set |session|'s [=list of animation frame callbacks=] to the empty list.
1. Set |frame|'s [=active=] boolean to <code>true</code>.
1. For each entry in |callbacks|, in order:
Expand Down