Draft
Conversation
It looks like recent changes to auth did not include videos, and so no auth was being sent when loading them.
mertalev
reviewed
Mar 11, 2026
Comment on lines
+70
to
+72
| if #available(iOS 15, *) { | ||
| VideoProxyServer.shared.session = session | ||
| } |
Member
There was a problem hiding this comment.
This is intentionally only set when getting an mTLS or basic auth challenge because it's less efficient than the default AVPlayer handling.
| companion object { | ||
| fun registerPlugins(ctx: Context, flutterEngine: FlutterEngine) { | ||
| HttpClientManager.initialize(ctx) | ||
| NativeVideoPlayerPlugin.dataSourceFactory = { OkHttpDataSource.Factory(HttpClientManager.getClient()) } |
Member
There was a problem hiding this comment.
Setting this is good, but we should confirm that it doesn't cache the video because that will trash the disk cache of the shared session.
Member
|
I was having problem with auth playing video on iOS and this PR also seems to fix it FYI |
Member
|
It will, but #26887 is the better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks like recent changes to auth did not include videos, and so no auth was being sent when loading them.