fix: reject promise on child error #10114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10107
If there is an error in the child iframe
beforeunload, the promise will never resolve, making us wait infinitely. Therefore, thetry{}catch{}block is not working as expected:logseq/libs/src/LSPlugin.core.ts
Lines 920 to 928 in 361d08d
This PR rejects child promise on error so that the
try{}catch{}block is catching the error.To test it, follow #10107 but change
@logseq/libsto the development one.One question, should I update
LSPlugin.core.jsin this PR?