Skip to content

Conversation

@anderson4j
Copy link
Collaborator

@anderson4j anderson4j commented Dec 5, 2025

Following this tutorial: https://docs.npmjs.com/trusted-publishers

I've set up trusted publishing for the npm packages on npmjs. The final part needed is this small permission change on the workflow, as well as making sure we run npm cli >= 11.5.1

Closes LS-49

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: f6784c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anderson4j anderson4j force-pushed the setUpTrustedPublishing branch from 55d9ccf to e646c68 Compare December 5, 2025 14:55
environment: publish-npm
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v4
Copy link
Collaborator Author

@anderson4j anderson4j Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is added so we get a new enough node version. When I tested on my own repo, the default was using node 20, and thus too low a npm version (10.x.y)
See this run for what we get when adding this "uses"-step
https://github.com/anderson4j/clonedLangSupp/actions/runs/19966528562/job/57259666256

As you can see, the npm version becomes 11.6.2 > 11.5.1, which is what we need according to the npm page for trusted publishing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this with the more correct approach of changing the setup-and-build action

… in publish-npm-packages

Also updates package to use node 24 just like CI will
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants