Bolt refactoring #1560
Merged
Bolt refactoring #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/bolt-refactor
branch
30 times, most recently
from
b1bb793 to
8bc069e
Compare
injectives
force-pushed
the
feature/bolt-refactor
branch
3 times, most recently
from
95a2a2d to
6b072b8
Compare
injectives
force-pushed
the
feature/bolt-refactor
branch
from
0c72478 to
784230e
Compare
injectives
force-pushed
the
feature/bolt-refactor
branch
2 times, most recently
from
72488b5 to
a9ac556
Compare
injectives
force-pushed
the
feature/bolt-refactor
branch
4 times, most recently
from
b65d6cb to
a8f8e1e
Compare
injectives
force-pushed
the
feature/bolt-refactor
branch
12 times, most recently
from
22c30bd to
8a5dfc4
Compare
injectives
force-pushed
the
feature/bolt-refactor
branch
from
8a5dfc4 to
d674aaa
Compare
gjmwoods
approved these changes
Oct 24, 2024
Contributor
gjmwoods
left a comment
gjmwoods
left a comment
There was a problem hiding this comment.
Looks great. Just some minor stuff 💪
...er/src/main/java/org/neo4j/driver/internal/bolt/pooledimpl/PooledBoltConnectionProvider.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @SuppressWarnings({"DuplicatedCode", "ConstantValue"}) | ||
| public void connect( |
Contributor
There was a problem hiding this comment.
this one is a bit of a beast but not sure if it can broken down to make it more readable. Looks correct though.
| null, | ||
| (ignored) -> {}) | ||
| .thenCompose(boltConnection -> { | ||
| var supports = boltConnection.protocolVersion().compareTo(new BoltProtocolVersion(4, 0)) >= 0; |
Contributor
There was a problem hiding this comment.
nit: could use static versions
driver/src/main/java/org/neo4j/driver/internal/bolt/basicimpl/NettyBoltConnectionProvider.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/bolt/basicimpl/NettyBoltConnectionProvider.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/neo4j/driver/internal/bolt/pooledimpl/PooledBoltConnectionProvider.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/neo4j/driver/internal/bolt/routedimpl/RoutedBoltConnectionProvider.java
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/cursor/ResultCursorImpl.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/cursor/ResultCursorImpl.java
Show resolved
Hide resolved
…/PooledBoltConnectionProvider.java Co-authored-by: Greg Woods <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.