Skip to content

pointer-events: none when not sticky #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbostock merged 4 commits into from
Jun 19, 2023
Merged

pointer-events: none when not sticky #1697

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37517cf
pointer-events: none when not sticky
mbostock Jun 16, 2023
648bfd5
add missing context in call to applyIndirectStyles
Fil Jun 16, 2023
9589596
regenerate snapshots
mbostock Jun 17, 2023
6eb1c86
greedy context copy
mbostock Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
greedy context copy
  • Loading branch information
@mbostock
mbostock committed Jun 19, 2023
commit 6eb1c86ffffed3c96eb39e5ede9e2301c2ac95dd
5 changes: 3 additions & 2 deletions src/interactions/pointer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ function pointerK(kx, ky, {x, y, px, py, maxRadius = 40, channels, render, ...op
// outermost render function because it will re-render dynamically in
// response to pointer events.
render: composeRender(function (index, scales, values, dimensions, context, next) {
context = {...context, pointerSticky: false};
const svg = context.ownerSVGElement;
const {data} = context.getMarkState(this);

Expand Down Expand Up @@ -100,10 +101,10 @@ function pointerK(kx, ky, {x, y, px, py, maxRadius = 40, channels, render, ...op
function render(ii) {
if (i === ii && s === state.sticky) return; // the tooltip hasn’t moved
i = ii;
s = state.sticky;
s = context.pointerSticky = state.sticky;
const I = i == null ? [] : [i];
if (faceted) (I.fx = index.fx), (I.fy = index.fy), (I.fi = index.fi);
const r = next(I, scales, values, dimensions, {...context, pointerSticky: s});
const r = next(I, scales, values, dimensions, context);
if (g) {
// When faceting, preserve swapped mark and facet transforms; also
// remove ARIA attributes since these are promoted to the parent. This
Expand Down