Location field cleanup #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
added
the
BLOCKED
binh-dam-ibigroup
removed
the
BLOCKED
miles-grant-ibigroup
approved these changes
May 2, 2023
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
All is working well thanks for the changes!
amy-corson-ibigroup
approved these changes
May 3, 2023
Contributor
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
Small issue with the favorite places getting rendered in double parentheses, but otherwise everything looks great! Thank you so much for doing this
| /** | ||
| * Create a LocationField location object from a persisted user location object. | ||
| */ | ||
| function makeLocationFieldLocation(favoriteLocation: Fields) { |
Contributor
There was a problem hiding this comment.
Maybe makeLocationFieldObject? makeLocationFieldLocation does seem a little unwieldy, but if that feels more appropriate I'll defer to you.
lib/util/user.js
Outdated
| name: address || name, | ||
| // HACK: If a place name and address are provided, put the address in parentheses | ||
| // to mimic the existing LocationField behavior for "work" and "home". | ||
| name: address && name ? `${name} (${address})` : address || name, |
Contributor
There was a problem hiding this comment.
This is unfortunately resulting in a double parenthesis on Home and Work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
@opentripplanner/location-fieldto the latest version, notably:PR Checklist