Skip to content

Conversation

@amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented May 4, 2023

Description:

  • Add aria-live to copy button in trip details to announce to AT that info was copied
  • Add aria-expanded to map button in printable itinerary to announce to AT that region was expanded.
  • Add role="link" to trip tools buttons acting as links

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [n/a] Are all languages supported (Internationalization/Localization)?
  • [n/a] Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for the changes!

@amy-corson-ibigroup amy-corson-ibigroup merged commit d0c7ea9 into dev May 5, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the aria-button-fixes branch June 27, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants