Route renderer a11y #904
Route renderer a11y #904
Conversation
… if both are same.
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Thanks for all this cleanup! New structure makes sense, just one quick potential rename
|
|
||
| type RouteRendererProps = { | ||
| export type RouteRendererProps = { | ||
| fullRender?: boolean |
There was a problem hiding this comment.
Should we rename this to expandedRender or renderName?
There was a problem hiding this comment.
I dropped fullRender in acc109a. For immediate purposes the custom route renderer uses leg.onColoredBackground.
There was a problem hiding this comment.
I would be tempted to refactor that leg.onColoredBackground TBH.
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Variable font size is looking a bit funky, otherwise this all looks good thank you for the cleanup
| // All GTFS bg colors look strange with the top border | ||
| leg={generateFakeLegForRouteRenderer(route, true)} | ||
| style={{ | ||
| fontSize: routeNameFontSize(routeName) |
There was a problem hiding this comment.
The variable font size might be causing problems...
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Working for me thanks for the changes!
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
This route name layout looks really nice! LGTM
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
This route name layout looks really nice! LGTM
Description:
Improves visual accessibility by requesting custom route renderers to fully render route names if needed (especially in the pattern viewer and stop viewer).
PR Checklist: