Support External Help Link #917
Conversation
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Works! Just a few nitpicks
lib/util/auth.js
Outdated
| url: '/help' | ||
| } | ||
| ] | ||
| export const accountLinks = (config) => { |
There was a problem hiding this comment.
nitpick: can we refactor this to take in extraMenuItems instead of the entire config?
lib/util/auth.js
Outdated
| export const accountLinks = (config) => { | ||
| const helpLink = | ||
| config?.extraMenuItems.find((link) => link.id === 'help') || undefined | ||
| const helpLinkUrl = helpLink ? helpLink.href : '/help' |
There was a problem hiding this comment.
Can we inline this?
| messageId: 'help', | ||
| // Add a target attribute if you need the link to open in a new window, etc. | ||
| // (supports the same values as <a target=... >). | ||
| // target: '_blank', |
There was a problem hiding this comment.
Is this supposed to be uncommented?
There was a problem hiding this comment.
This exists in dev, but I think it's just a demonstration? Seems like weird behavior for this to open a new tab by default
There was a problem hiding this comment.
Good call. We can leave it commented out for now!
| const mapStateToProps = (state) => { | ||
| return { | ||
| auth0Config: getAuth0Config(state.otp.config.persistence), | ||
| config: state.otp.config, |
There was a problem hiding this comment.
Once accountLinks is extracted this can be refactored to only extract the part of the config we need
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Looking good! Just one small crash fix and we should be good to go
| auth0Config: getAuth0Config(state.otp.config.persistence), | ||
| config: state.otp.config, | ||
| configLanguages: state.otp.config.language, | ||
| extraMenuItems: state.otp.config.extraMenuItems, |
There was a problem hiding this comment.
You need optional chaining here!
Description:
If there is an external "help" link supplied in the config, the "help" option inside the account dropdown will direct users to the external web address. An icon will also be added indicating the link is an external link.
PR Checklist: