Call Taker CSS Cleanup #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
approved these changes
Jun 7, 2023
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
LGTM with one minor change.
| const advancedSearchStyle = { | ||
| background: 'white', | ||
| boxShadow: 'none', | ||
| display: expandAdvanced ? undefined : 'none', |
Collaborator
There was a problem hiding this comment.
Actually, turn expandAdvanced into whether to render the thing at all (so you can delete this variable).
Collaborator
Author
There was a problem hiding this comment.
I think I tried this and it causes problems with the state because the forms disappear
Signed-off-by: miles-grant-ibigroup <[email protected]>
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Jun 14, 2023
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
nice small improvement! Thanks!
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The advanced options no longer floats. This makes it easier to see what's where.
PR Checklist:
Before:
After:
