(Mailables): Support Simultaneous Small and Large Print #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miles-grant-ibigroup <[email protected]>
Contributor
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
Could you get rid of the checkboxes and just have two inputs? One for small format one for large?
Having trouble understanding why you'd want to select both checkboxes without being able to control the number for each, but it it makes sense in context I trust you
| } | ||
| return rows | ||
| }) | ||
| .flat() |
Contributor
There was a problem hiding this comment.
Nitpicky, but could just change the above map to flatMap
Collaborator
Author
There was a problem hiding this comment.
This is much cleaner thanks!
amy-corson-ibigroup
approved these changes
Jun 20, 2023
Contributor
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
Whoops, meant to approve! Nothing blocking
miles-grant-ibigroup
restored the
mailalbes-both-small-and-large-print
branch
miles-grant-ibigroup
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The mailables large print feature currently disables the small print on the resulting pdf. This PR corrects this, allowing for simultaneous large and small prints. Unfortunately, there is no way to change the count for the second size. Not sure how best to solve this.
PR Checklist: