Fix grouped itineraries a11y and regressions #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
changed the title
amy-corson-ibigroup
approved these changes
Jun 30, 2023
Contributor
amy-corson-ibigroup
left a comment
amy-corson-ibigroup
left a comment
There was a problem hiding this comment.
Looks good to me! I really like the TimeButton component
| setActiveItinerary?: SetActiveItineraryHandler | ||
| } | ||
|
|
||
| const TimeButton = ({ |
Contributor
There was a problem hiding this comment.
Thoughts on pulling this component out into its own file?
Collaborator
Author
There was a problem hiding this comment.
Sure if it were used in multiple components, but that's not the case right now.
miles-grant-ibigroup
approved these changes
Jul 3, 2023
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Working for me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ui_activeItineraryis not shown.PR Checklist