feat: replace native pattern select with dropdown #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
requested changes
Jul 11, 2023
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Working well! Just a few small nitpicks
miles-grant-ibigroup
approved these changes
Jul 13, 2023
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Working great thanks so much!
Collaborator
|
I see some flashing when switching patterns, can that be addressed? |
Collaborator
Basically, the route viewer flashes briefly during the transition from one pattern to another. |
binh-dam-ibigroup
requested changes
Jul 13, 2023
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Can you address the flashing, please?
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
See a few cleanup items.
| button { | ||
| display: flex; | ||
| align-items: center; |
Contributor
Author
binh-dam-ibigroup
requested changes
Jul 14, 2023
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Sorry @amy-corson-ibigroup, I noticed that with this PR, the ability to navigate back is affected (see comment).
| span { | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; |
binh-dam-ibigroup
approved these changes
Jul 17, 2023
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaces the pattern select with the more accessible Dropdown component
PR Checklist: