Skip to content

gh-111696: type(str) returns the fully qualified name #112129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 2 commits into from
Closed

gh-111696: type(str) returns the fully qualified name #112129

vstinner wants to merge 2 commits into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 15, 2023 •
edited by github-actions bot
Loading

  • Update modules:

    • enum
    • functools
    • optparse
    • pdb
    • xmlrcp.server

  • Update tests:

    • test_dataclasses
    • test_descrtut
    • test_cmd_line_script

📚 Documentation preview 📚: https://cpython-previews--112129.org.readthedocs.build/

@vstinner
pythongh-111696: type(str) returns the fully qualified name
f282b93 
* Update modules:

  * enum
  * functools
  * optparse
  * pdb
  * xmlrcp.server

* Update tests:

  * test_dataclasses
  * test_descrtut
  * test_cmd_line_script
@bedevere-app bedevere-app bot mentioned this pull request Nov 15, 2023
Closed
@vstinner
Copy link
Member Author

vstinner commented Nov 15, 2023

I failed to fix test_basics() of test_enum which fails. But well, I don't think that this backward incompatible change is a good idea, so I don't plan to decidate too much time to it :-)

@vstinner
Copy link
Member Author

vstinner commented Nov 16, 2023

I created this PR to show that changing str(type) is a bad idea: it breaks the backward compatibility and it requires to change too much code which currently works fine. I close this PR.

@vstinner vstinner closed this Nov 16, 2023
@vstinner vstinner deleted the type_str branch November 28, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian will be requested when the pull request is marked ready for review gaogaotiantian is a code owner

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy will be requested when the pull request is marked ready for review terryjreedy is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger will be requested when the pull request is marked ready for review rhettinger is a code owner

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman will be requested when the pull request is marked ready for review ethanfurman is a code owner

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith will be requested when the pull request is marked ready for review ericvsmith is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner