Open
Conversation
added 2 commits
October 28, 2024 14:17
Member
|
Thanks! I'll take a look this week. |
Author
|
Is there anything I can do to help speed things up |
Member
|
I have this added in a separate code base along with some extra features. I'll probably pull in that code instead, but I want to give you credit for the idea and your work 🙂 |
Author
|
Thank you very much for your work! Giving me (part) of the credit is a nice thought but really not necessary. I am just happy to help. |
Author
|
Any news on this? I am afraid my sentences will stop working once you pull in your code, so I've hold off on using these changes in "production". |
Author
|
This repo hasn't seen any development, is there another project we should use now? I read that some parts of wyoming are getting deprecated? But I am not sure if this exact part of the project is impacted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should close #4 .
It definitely takes away from the beauty of the recursion, but it works
Please let me know if/how I can improve this PR and thank you for all your fantastic work!
What it does: A dict is used to note what has been changed in an input template. After a sentence has been created the substitutions of the input sentence are used to change the output sentence accordingly.