Skip to content

Fix JSON::GeneratorError#detailed_message with Ruby < 3.2 #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Mar 5, 2025
Merged

Fix JSON::GeneratorError#detailed_message with Ruby < 3.2 #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/json/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,13 @@ def initialize(message, invalid_object = nil)
end

def detailed_message(...)
# Exception#detailed_message doesn't exist until Ruby 3.2
super_message = defined?(super) ? super : message

if @invalid_object.nil?
super
super_message
else
"#{super}\nInvalid object: #{@invalid_object.inspect}"
"#{super_message}\nInvalid object: #{@invalid_object.inspect}"
end
end
end
Expand Down
8 changes: 8 additions & 0 deletions test/json/json_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,14 @@ def test_json_generate
end
end

def test_json_generate_error_detailed_message
error = assert_raise JSON::GeneratorError do
generate(["\xea"])
end

assert_not_nil(error.detailed_message)
end

def test_json_generate_unsupported_types
assert_raise JSON::GeneratorError do
generate(Object.new, strict: true)
Expand Down