Skip to content

Conversation

@kares
Copy link
Contributor

@kares kares commented Oct 27, 2025

as mentioned in the commit and visible from the test, StringIO#read suffers from the same issue as jruby/jruby#9035

@kares kares changed the title fix code range on read (jruby) reset buffer's code range on read (jruby) Oct 27, 2025
Copy link
Contributor

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch... these modifies should all be clearing codeRange too. Just one typo to fix and this can merge.

@kares
Copy link
Contributor Author

kares commented Nov 4, 2025

🔴 failures don't seem related, same happens on master

@kou
Copy link
Member

kou commented Nov 4, 2025

Right. We should fix them in a separated PR.

@headius headius merged commit 8156f1c into ruby:master Nov 4, 2025
49 of 53 checks passed
@headius
Copy link
Contributor

headius commented Nov 4, 2025

All good here!

@kou I can release or you can do it, let me know.

@kou
Copy link
Member

kou commented Nov 5, 2025

You can do it!

@headius
Copy link
Contributor

headius commented Nov 5, 2025

@kou Oh, I thought I had push privileges for the gem but I guess I do not!

@kou
Copy link
Member

kou commented Nov 5, 2025

We have trusted publishing configuration in our CI. So we can push this gem by pushing release note https://github.com/ruby/stringio/blob/master/NEWS.md and running rake release.

Do you want me to release a new version?

@headius
Copy link
Contributor

headius commented Nov 5, 2025

Oh yes, I forgot about that. I can push a release. Thank you for the help!

@headius
Copy link
Contributor

headius commented Nov 5, 2025

I'm sorry, on second thought I am unsure how to proceed. I see there are release commits against NEWS.md, but not all of them are tagged, and there's been a lot of changes since April.

commit 389f80bff36f99df624a1c03eb3aa14e6ce8e6ec
Author: Sutou Kouhei <[email protected]>
Date:   Mon Apr 21 11:38:27 2025 +0900

    Add 3.1.7 entry

commit 942ac04eacfb05342befd1c2f75858bb7c60b970 (tag: v3.1.6)
Author: Charles Oliver Nutter <[email protected]>
Date:   Tue Mar 25 12:29:54 2025 -0500

    Add 3.1.6 entry

As I have never done a release of StringIO this way before, perhaps you could do this one and educate me on the process?

@kou
Copy link
Member

kou commented Nov 9, 2025

OK. I'll release a new version in a few days.

@kou
Copy link
Member

kou commented Nov 12, 2025

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants