Fix : TypeError in IntegralAffineCurve.function_field() for non-default variable names#41786
Open
PrafulVRaj wants to merge 1 commit intosagemath:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When AffineSpace is constructed with names other than the default (x, y), simple_model()/separable_model() rename the base-field generator (e.g. y to y_) to avoid a collision in the extension tower. The Horner-scheme evaluator in _nonsingular_model used .x on function-field elements, which bypasses coercion and returns values in Frac(k[y]) rather than in FR = Frac(k[y,z]). Sage has no registered coercion between these two differently-named fraction fields, so the accumulation fails with TypeError.
Fix
Build an explicit ring homomorphism base_to_FR from M.base_field() to FR before entering the evaluate closure, and replace ._x with base_to_FR(). This routes every coefficient through Sage's public coercion machinery and guarantees it lands in FR regardless of generator naming.
Fixes #41643
📝 Checklist